Conversation
✅ Deploy Preview for base44-platform-starter ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for sunny44-builder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ozsay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate Sunny's user provisioning and non-chat app operations to
@base44/sdk/platform/server, backed by the exact published preview@base44-preview/sdk@0.8.48-pr.283.2de4c8afrom JavaScript SDK PR #283.asUser(externalId)clients. The key needs both provisioning and token-minting permissions.@base44/sdk, so a later stable release requires only a dependency change. Exempt only@base44-preview/sdkfrom the local release-age filter; keep registry/proxy routing intact.The integration is organized as getting-started code: connection lifecycle in
base44Link.ts, explicit SDK calls and browser mapping inbase44AppOperations.ts,and persistent storage in
base44TokenStore.ts. The README gives a reading order.Testing
npm ciagainst the updated lockfile.npm run platform-sdk:test— integration test passes against the installed package, covering token persistence and reuse, app projections, initial creation, preview/deploy mapping, transient mint failure, and disconnect.npm run typecheck— passes.npm run build— passes with placeholder auth configuration; no production credentials or live provisioning/deployment calls.git diff --checkpasses.Dependency review
Review the lockfile change: adds the exact SDK preview and 21 transitive packages shipped by the shared runtime/platform SDK package. No existing package versions changed. The platform server entry point does not import the runtime SDK, although the shared package installs its dependencies.
Intent (for reviewers & PR Autofix)
What this PR does
Make Sunny a consumer of the published platform server SDK for provisioning users and managing apps, retaining its application-specific persistence and authorization boundaries.
Key decisions & why
Optimize the starter for human readers: explicit steps, descriptive names, and a separate storage adapter keep the SDK integration easy to follow.
One API key; the SDK's optional storage defaults to memory, while Sunny supplies its existing persistent token adapter.
The published preview is pinned under the final package alias so imports remain stable when switching to a release.
Projected SDK results preserve Sunny's browser response conventions without exposing unrelated upstream fields.
What NOT to touch
Tradeoffs / follow-ups