refactor(core): decouple static server - #40
Open
barelyhuman wants to merge 5 commits into
Open
Conversation
Move assets/islands/client serving out of the node adapter into createStaticMiddlewares, defaulting to sirv so kernels can reuse it.
Allow plugin users to replace the sirv-compatible file server via
adex({ kernel: { staticServer } }), wired through virtual:adex:static-server
into the node adapter. Default remains sirv; false disables serving.
Custom staticServer modules receive { paths } and own mounting entirely.
Sirv URL rewriting (__originalUrl /assets|/islands) stays only in the
default createStaticMiddlewares implementation.
Keep sirv URL-rewrite wiring inside adex's default static plugin. Users switch or disable it via kernel.staticServer; the adapter only mounts whatever plugin virtual:adex:static-server resolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.