Repository navigation
Fix LoongArch BREAK instruction encoding - #3917
Merged
Merged
Conversation
Owner
|
These unsupported architectures are not tested or maintained in any way so it's entirely subject to whatever PRs are submitted without any checking of platform specific functionality. Any changes that only affect those paths will be accepted blindly because it is obviously not realistic for me to check e.g. whether this change is correct or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
0x150000ULL is actually
ORinstruction.LoongArch Reference Manual Vol.1 Appendix B(en, zh) list instruction encoding in binary and noted:
it looks like counted wrong number of leading zeros during manually binary to hex conversion
see also: