Skip to content

MEAP review feedback - Ch1 and 2 - #9

Merged
bahree merged 5 commits into
mainfrom
meap-chap-1-5
Sep 14, 2026
Merged

bahree merged 5 commits into
mainfrom
meap-chap-1-5

Conversation

@bahree

@bahree bahree commented Sep 14, 2026

Copy link
Copy Markdown
Owner

What does this PR do

Related issue

Which chapter or area does this touch

How to test

# example
cd code
pytest chapter05/tests -q

Checklist

  • Tests added or updated for the change (if it's a bug fix or behavior change)
  • pytest -q passes from code/
  • ruff check . passes from code/
  • README or chapter README updated if user-facing instructions changed
  • No secrets, API keys, or personal data in the diff
  • No large binary artifacts (model checkpoints, training runs) in the diff
  • The change does not alter file paths the book references in listings

Additional context

@bahree

bahree commented Sep 14, 2026

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request

bahree and others added 4 commits September 13, 2026 17:23
Co-authored-by: bahree <3529468+bahree@users.noreply.github.com>
Co-authored-by: bahree <3529468+bahree@users.noreply.github.com>
Co-authored-by: bahree <3529468+bahree@users.noreply.github.com>

Copilot AI commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved. The branch has been synced and conflicts are fixed (merge commit a57c2da), with follow-up consistency updates in 2f50645.

@bahree
bahree merged commit f326781 into main Sep 14, 2026
4 checks passed
Copilot stopped work on behalf of bahree due to an error September 14, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants