Show a one-sentence description for each app in the /edit app store - #23
MetzinAround with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: MetzinAround <65838556+MetzinAround@users.noreply.github.com>
Co-authored-by: MetzinAround <65838556+MetzinAround@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues remain.
Pull request overview
Adds existing app descriptions to /edit/ app store cards.
Changes:
- Builds description mappings by slug and badge folder name.
- Passes descriptions to
BadgeManager. - Displays descriptions for matching apps.
File summaries
| File | Description |
|---|---|
src/pages/edit.astro |
Loads app metadata and creates description mappings. |
src/components/badge-manager.tsx |
Attaches and displays app descriptions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Does this still dynamically fetch the apps on every page reload? If so, LGTM. |
|
@copilot Charlie asked "Does this still dynamically fetch the apps on every page reload? If so, LGTM." look thruogh and check that it does or doesn't, don't change anything yet. |
Yes. |
The app store list on
/edit/showed only an icon, a name, and an Add button, so visitors had no idea what an app does before pushing it to their badge. This wires the existing app descriptions from theappscontent collection into that list.src/pages/edit.astroappscontent collection at build time and passes anappDescriptionsmap toBadgeManager.fileLocation, since the catalog folders inbadger/homedon't always match the slug (monaquest→quest,flappymona→flappy).src/components/badge-manager.tsxBadgeManagertakes an optionalappDescriptionsprop;loadStoreattaches the matching description to eachStoreApp.text-xs text-muted-foreground. Apps with no match render exactly as before.Copy is reused verbatim from existing app metadata, so descriptions stay in sync with
/apps/and nothing new was invented. No new components, tokens, or styles.Review feedback not applied
StoreAppCardcomponent and restyling the card title to monospace uppercase: a broader refactor of the existing dense inline markup inbadge-manager.tsx, worth doing separately.appDescriptionsto a dependency array:loadStoreis a plain per-render function, and the prop is static build-time data.