Repository navigation
feat(template): allow setting namespace labels and annotations from the start (issue 73) - #1
Open
bacluc-agent wants to merge 12 commits into
Open
bacluc-agent wants to merge 12 commits into
bacluc-agent wants to merge 12 commits into
Conversation
BacLuc
reviewed
Oct 15, 2026
…he start (issue 73)
…s from the start (issue 73)" This reverts commit c7df9f8.
Owner
Author
|
Checking if there might be additional review comments after latest commit... |
Owner
Author
|
The single review comment (BacLuc on 2026-10-15) requested default to . Current head already has in defaults, in parameters.adoc, and namespace emission gated. No outstanding review comments require changes. |
Owner
Author
|
Review comment 4280706664 (BacLuc) requested createNamespace default false; current head 45b1486 already satisfies this. No outstanding changes needed. |
3 tasks done
bacluc-agent
force-pushed
the
feat/namespace-labels-annotations
branch
from
October 21, 2026 21:08
7ac4ca6 to
6564c37
Compare
Add a special test case which removes the namespace parameters from the class defaults, to verify that the component still compiles when they aren't declared. (cherry picked from commit a5f98fb)
(cherry picked from commit 7ac4ca6)
The fallback defaults are read with std.get, the pattern the template already uses in component/app.jsonnet, so that params stays the plain inventory parameters. The redundant workflow step which stripped the namespace parameters with sed is dropped: the no-namespace-params test case of the post-gen hook already covers that check in the template's own test machinery.
Owner
Author
|
re-trigger tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/bacluc-agent/agent-vshn-todo/issues/73
Tracking issue: https://github.com/bacluc-agent/agent-todo/issues/73
Management summary
This PR adds opt-in namespace creation with configurable namespace labels and annotations. The sole human review request — default
createNamespacetofalse(breaking change otherwise) — is satisfied at branchfeat/namespace-labels-annotations, head87bff3cd7f1ceeb8e8f22788f29171f322d23b91; this run re-audited every PR review comment, found none outstanding, and pushed no source changes. A fresh local template suite at that head (rootmake test, rendered-template lint, golden cases defaults / namespace opt-in / legacy parameters) passed and the read-only review approved. Assumption: namespace creation stays opt-in so existing components are unaffected.Verification evidence
Template tests run at the exact current head
87bff3c(target-repo suite, not runner auto-CI): default golden, namespace opt-in golden, legacy-parameter golden, rendered-template lint. This session additionally re-ranmake test,make -C test-component lint, andgolden-diff-alllocally at the same head — all exit 0 — confirming the default render emits no00_namespace.yaml, the opt-in render emits it with user labels/annotations preserved, and parameter-less legacy classes still compile.Action runs
87bff3c; linked jobs cover default output, namespace opt-in, legacy compatibility, and lint.