feature: support dispose and re-init in the android exception handler - #402
Open
KishanPRao wants to merge 1 commit into
Open
KishanPRao wants to merge 1 commit into
KishanPRao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Android exception handler hands exceptions back to the app after
dispose()and reports again after re-init or a JS reload.Changes
BacktraceAndroidBackgroundUnhandledExceptionHandler.java: restore the previous handler on dispose, report again after re-init, clean up on JS reload.build.gradle: allowandroid.util.Login unit tests.BacktraceAndroidBackgroundUnhandledExceptionHandlerTest.java: add tests for dispose, re-init and reload.ref: BT-7708