Repository navigation
Rank PNG, WebP and AVIF sources above favicon.ico - #2
Merged
Merged
Conversation
Format outranked declared size, so a site's favicon.ico (rarely larger than 64px) beat its 512px PNG and every larger variant was upscaled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Candidate sources are ranked by format first; declared size only breaks ties within a format. With
icoat priority 1 andpngat 2, a site's/favicon.icoalways won — even over a declared 512×512 PNG. Since afavicon.icorarely holds more than 64px, every larger variant (180, 192, 512) ended up upscaled. Seen on artsenverklaringen.nl, whose.icotops out at 64px next to a 512px PNG.Change
config/favicon.php:png/webp/avifnow rank 1 andicoranks 2 (svgstays first,jpg/gifunchanged). Declared PNGs then sort largest-first; a site offering only an.icostill uses it, and the/favicon.icofallback stays last.favicon.ico(sizes="any") plus 32px and 512px PNGs resolves to the 512px PNG. Fails on the old defaults, passes now; full suite green (33 tests).Apps that published the config keep their own
source_priorityand need the same edit.🤖 Generated with Claude Code