Repository navigation
Conversation
byan1197
commented
Oct 9, 2026
byan1197
commented
- Bundles python dependencies with Zensical
- Sets up CI
- Added codeowners @backstage/techdocs-maintainers
- Added mock docs for testing
setting up ci Signed-off-by: Bond Yan <bondy@spotify.com>
Signed-off-by: Bond Yan <bondy@spotify.com>
Signed-off-by: Bond Yan <bondy@spotify.com>
melissawimberly
left a comment
melissawimberly
left a comment
There was a problem hiding this comment.
Two things to look at, but otherwise good to go
-
latest gets overwritten by unreleased code (.github/workflows/release.yml:29): every push to main builds and pushes ghcr.io//techdocs-zensical:latest, and a published release also tags latest. So any merge after a release replaces the released image with unreleased code. A fix would be to tag main builds as something like edge or main, or the commit SHA, and keep latest for releases only.
-
The build may fail on the new base image (Dockerfile:17-21): the base changed from python:3.14-alpine to zensical/zensical:0.0.69, but the next step still runs apk update && apk add ... graphviz plantuml. If the new image isn't Alpine-based, apk won't exist and the build breaks there. Running docker run --rm zensical/zensical:0.0.69 cat /etc/os-release would settle it.
2 participants
