BABEL-5975: Add engine hooks for original identifier name resolution in errors - #780
Open
anju15bharti wants to merge 1 commit into
Conversation
…ssages Add bbf_get_original_constraint_name_hook and bbf_get_original_index_name_hook for resolving truncated constraint/index names back to original user-visible names in error messages (FK violations, unique constraint violations). - execMain.c: Hook definitions + unique constraint name resolution - ri_triggers.c: FK constraint name resolution in RI trigger errors - nbtinsert.c: Unique index violation name resolution - executor.h: Hook type declarations Signed-off-by: anju15bharti <abanju@amazon.com>
1 task
anju15bharti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds hooks that allow the Babelfish extension to resolve original full-length names at error emission sites, so TDS clients see meaningful names instead of truncated internal ones.
Hooks (executor.h):
constraint name before emitting constraint violation errors
index name before emitting unique violation errors
Part 5 of 5 for BABEL-5975 (Long Identifier Support).
extension : babelfish-for-postgresql/babelfish_extensions#4924
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.