Skip to content

Keep dark mode surfaces on the chassis - #119

Merged
baanish merged 2 commits into
mainfrom
cursor/fix-dark-mode-light-surfaces-3c76
Sep 20, 2026
Merged

baanish merged 2 commits into
mainfrom
cursor/fix-dark-mode-light-surfaces-3c76

Conversation

@baanish

@baanish baanish commented Sep 17, 2026

Copy link
Copy Markdown
Owner

The generated-link result panel and header identity mark stayed cream after the dark bench rebuild, so a dark-mode page still flashed a light paper sheet.

This keeps those surfaces on the chassis in dark mode:

  • Carbon transfer stock now uses a dark sheet with ivory ink, recessed wells, and a mint stamp
  • The header identity mark uses the charcoal key face instead of lifted bone
  • Active sample rows no longer flip to cream when the shell is dark
  • Light mode cream stock and bone mark are unchanged

A Playwright check asserts the mark and generated-link backgrounds stay below the light-surface luminance threshold in dark mode.

Test plan

  • Open / in dark mode, generate a link, and confirm the result panel matches the chassis
  • Confirm the header mark is charcoal in dark mode and still bone in light mode
  • Edit an open artifact, generate a new link, and confirm the shared result panel is also dark
  • Walk markdown, code, diff, CSV, JSON, Security, URL explainer, mermaid, and a 390px viewport in dark mode
  • CI=1 npx playwright test tests/e2e/viewer.spec.ts --project=chromium — 33 passed, including the new luminance check

Walkthrough

Before (cream transfer stock on a dark page):

Dark mode generated link panel before the fix

After (same panel on the chassis):

Dark mode generated link panel after the fix

Light mode still uses cream stock:

Light mode generated link panel still cream

dark_mode_generated_link_fix.mp4

Open in Web Open in Cursor 

The generated-link carbon sheet and header identity mark stayed cream after the dark bench rebuild. Dark theme now uses a carbon sheet and charcoal mark, and a Playwright check guards those backgrounds.

Co-authored-by: aanishbhirud <aanishbhirud@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c29782b4-4fb9-4826-b1a6-89eb40fe132e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 17, 2026

Copy link
Copy Markdown

Deploying agent-render with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7da4ef7
Status: ✅  Deploy successful!
Preview URL: https://c0589ae7.agent-render.pages.dev
Branch Preview URL: https://cursor-fix-dark-mode-light-s.agent-render.pages.dev

View logs

@baanish
baanish marked this pull request as ready for review September 20, 2026 22:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T22:57:39.899746Z 203ef2b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 203ef2b. Configure here.

Comment thread tests/e2e/viewer.spec.ts Outdated
@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the prior ineffective gradient check has been corrected and no new actionable defects remain.

Summary

This PR keeps generated-link surfaces and the header identity mark visually consistent with the dark chassis while preserving the existing light theme.

  • Adds dark carbon-stock tokens, recessed output fields, and mint confirmation styling.
  • Applies the dark control-face treatment to the identity mark and active sample rows.
  • Aligns the design documentation and canonical palette metadata with the implementation.
  • Strengthens the Playwright regression test to inspect gradient colors as well as solid backgrounds.

Reviews (2) · Last reviewed commit: "Make the dark-mode mark check read the g..."

Comment thread tests/e2e/viewer.spec.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 203ef2b257

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/e2e/viewer.spec.ts Outdated
The identity-mark assertion only sampled backgroundColor, which is transparent when the dark mark uses a linear-gradient. The check now uses the brightest opaque stop from the painted surface.

Co-authored-by: aanishbhirud <aanishbhirud@gmail.com>
@kilo-code-bot

kilo-code-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Verified against 7da4ef7 (cursor/fix-dark-mode-light-surfaces-3c76): dark-theme generated-link and identity-mark surfaces now use the chassis material, light mode is byte-identical to the replaced literals, every custom property referenced by the changed rules is defined in both :root and .dark, and no later or inline rule overrides the new dark selectors. The earlier identity-mark luminance concern is resolved at this revision: the check now reads gradient stops and takes the brightest opaque stop, so a light face fails instead of collapsing to transparent black.

Files Reviewed (4 files)
  • .impeccable/design.json
  • DESIGN.md
  • src/app/globals.css
  • tests/e2e/viewer.spec.ts

Validation was not executed in this read-only review; findings are based on static inspection.


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

@baanish
baanish merged commit e947af7 into main Sep 20, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants