Repository navigation
feat(ui): add fresh Jira preview test banner below header - #43
Open
ayushtr-aws wants to merge 1 commit into
Open
ayushtr-aws wants to merge 1 commit into
ayushtr-aws wants to merge 1 commit into
Conversation
Adds a compact banner under the app header for end-to-end Jira/Amplify preview verification, using existing CSS variables for theming. Co-Authored-By: Claude <noreply@anthropic.com> Task-Id: 01M2R6CJKDGEXWP5542QWS5DFQ Prompt-Version: 1c9c10e027a2
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Owner
Author
|
🖼️ Preview screenshot From preview link — captured automatically by ABCA after the deploy finished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds a compact, always-visible banner immediately below the app header on the soccer-app homepage with the exact text:
Fresh Jira preview test: Sep 17.soccer-app/src/App.tsx: new.preview-bannerelement rendered between<header className="app-header">and<div className="app-layout">, withrole="status".soccer-app/src/App.css: banner styling using the existing CSS custom-property design tokens (--accent-brightbackground, white text,--header-borderbottom border) for good contrast in both light and dark themes;.app-layoutheight adjusted fromcalc(100vh - 73px)tocalc(100vh - 73px - 36px)so the banner does not push content and stays visible without scrolling on desktop; a mobile tweak in the existing@media (max-width: 768px)block reduces font size/padding, and the banner wraps rather than overflowing on narrow viewports.Issue: TG-24 — end-to-end test of a fresh Jira ticket through ABCA → GitHub PR → AWS Amplify PR preview → screenshot feedback. Leave this PR open for preview verification.
Build and test results
Dependencies were not present in the container (
tsc/oxlintnot found), sonpm installwas run insidesoccer-appfirst.mise run build(tsc -b && vite build) — PASS. Output:✓ 20 modules transformed,dist/assets/index-*.css 10.66 kB,dist/assets/index-*.js 213.89 kB,✓ built in 117ms. No TypeScript errors.mise run lint(oxlint) — PASS, no diagnostics reported.testscript, no Vitest/Jest), so no unit tests were run. Manual verification instead: grepped the production bundle and confirmed the exact stringFresh Jira preview test: Sep 17is present once insoccer-app/dist/assets/index-*.js.Decisions made
.app-header(not inside it), matching the "immediately below the header" wording and keeping header flex layout untouched.min-height) from the desktop.app-layoutheight, consistent with the existing hard-coded73pxheader offset in this file, so the viewport does not gain a scrollbar and the banner is visible without scrolling.Agent notes
What went well
App.cssstructure (sectioned comments, design tokens inindex.css) made it obvious where to put the new styles.What was difficult
node_modulesmissing despite setup reporting success, so the firstmise run build/mise run lintfailed withtsc: not found/oxlint: not found. Runningnpm installinsoccer-appfixed both.height: calc(100vh - 73px)for.app-layouttied to the header's rendered height. Inserting anything between header and layout requires updating that magic number, otherwise the page overflows the viewport. Worth noting for anyone adding chrome around the header in future.Repo conventions discovered
mise.tomldefinesbuild/lint/devtasks that shell intosoccer-app.oxlint(no ESLint config); no test framework at all.:rootand:root.dark-modeinsrc/index.css; dark mode is the default and is toggled by adding a class to<html>fromApp.tsx.feat(ui): make dark mode the default theme).Suggestions for future tasks
73px/36pxviewport-height math with a flex-based layout (.appis alreadydisplay: flex; flex-direction: column, so.app-layout { flex: 1; min-height: 0 }would remove the magic numbers entirely).npm installmay be needed insoccer-appbefore runningmise run build/lint.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.