fix(deploy-on-aws): add Kiro post-install script for aws-architecture-diagram scripts - #272
Open
iamharshtita wants to merge 1 commit into
Open
iamharshtita wants to merge 1 commit into
iamharshtita wants to merge 1 commit into
Conversation
…-diagram
The compound-plugin converter only copies skills/<name>/ and does not
install the plugin-level scripts/ folder. The aws-architecture-diagram
skill references these via ${PLUGIN_ROOT}/scripts/lib/, which has no
equivalent in Kiro, so fix_step_badges.py and drawio_url.py are never
found after a Kiro install.
Add install-kiro-scripts.sh that:
- Downloads plugin-level scripts into the installed skill directory
- Installs the defusedxml Python dependency via requirements.txt
- Patches ${PLUGIN_ROOT} references in SKILL.md to the actual path
- Supports both global (~/.kiro) and project-scoped (.kiro/) installs
Update README.md Kiro section with the required post-install step.
Zero impact on Claude Code, Codex, or Cursor installs.
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of the
project license.
iamharshtita
requested review from
a team,
arnewouters,
krokoko and
rshevchuk-git
September 11, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Kiro users install the
deploy-on-awsplugin using the documentedcompound-pluginconverter, theaws-architecture-diagramskill is partially installed —SKILL.mdandreferences/are copied correctly, but the plugin-levelscripts/folder is never included.This happens because the converter's
copySkillDirfunction only walksskills/<skill-name>/and has no concept of plugin-level shared assets. Theaws-architecture-diagramSKILL.md references these scripts via${PLUGIN_ROOT}/scripts/lib/, a Claude Code runtime variable that has no equivalent in Kiro. As a result,fix_step_badges.pyanddrawio_url.pyare silently missing after every Kiro install, causing the diagram skill to produce corrupted preview URLs and unvalidated badge positions.This PR adds
install-kiro-scripts.sh— a lightweight post-install script for Kiro users that downloads the missing scripts, installs their Python dependency (defusedxml), and patches the${PLUGIN_ROOT}path references inSKILL.mdto the actual installed location. The README Kiro section is updated with this as a required step after the existingcompound-plugininstall command.Related
npx skills addaws-diagram-mcp-serverdeprecated but replacement not available for KiroChanges
plugins/deploy-on-aws/scripts/install-kiro-scripts.sh— new post-install script for Kiro that:fix_step_badges.py,drawio_url.py,fix_icon_colors.py,fix_nesting.py,post_process_drawio.py,validate_drawio.py, andaws4-shapes.jsoninto~/.kiro/skills/aws-architecture-diagram/scripts/lib/defusedxmlviarequirements.txt${PLUGIN_ROOT}→ actual skill path inSKILL.md--projectflag for project-scoped installs (.kiro/vs~/.kiro/)README.md— adds "Install scripts for aws-architecture-diagram (required)" section under the Kiro install instructions with the one-line curl command for both global and project-scoped installsNo changes to Claude Code, Codex, or Cursor install paths.
mise buildpasses locally with no new errors or warnings introduced by these changes.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.