Conversation
Read-only, fully automated Amazon FSx for NetApp ONTAP operational review: 46 checks across Backup, Observability, Operations, Performance, and Security via public AWS APIs (fsx, cloudwatch, backup, ec2). Includes references, report template, and structure/best-practices/functional eval results. Wires least-privilege IAM into the shared cloudformation/devops-agent-skill-policies.yaml via a new EnableAwsFsxnOperationsReview toggle.
5 of 9 tasks
Author
|
@aws/tools-for-devops-agent-admins first-time contribution — a read-only FSx for NetApp ONTAP operational-review skill (Storage domain). Could a maintainer help triage and assign a Storage TFC SME for the domain review? Happy to iterate. Eval results are committed and the local validate-skill-evals check passes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A new skill,
aws-fsxn-operations-review: a strictly read-only, fully automatedoperational review for Amazon FSx for NetApp ONTAP (FSxN). It self-discovers all
ONTAP file systems in an account/region and evaluates 46 checks across 5 pillars
— Backup, Observability, Operations, Performance, Security — using only public AWS
APIs via
use_aws(fsx,cloudwatch,backup,ec2). Output is a prioritized,evidence-based findings report keyed to check IDs; a full tabular report template is
available for the Evaluation agent / on request.
Works for production and pre-production. No manual steps, no ONTAP CLI, no
Create*/Update*/Delete*, no data-plane access.Why it's not a duplicate
aws-backup-coverage-reviewanswers "what across my account isn't protected by AWSBackup" — account-wide, AWS Backup-centric.
pillars" — FSxN-specific, multi-pillar. Its backup checks look at FSxN-native
snapshots, SnapMirror/DR, and AWS Backup coverage for FSxN volumes specifically,
alongside performance/security/ops checks the backup skill doesn't cover.
FSxN-specific correctness
DeploymentTypeending_2) don't emitStorageCapacityUtilization; SSD utilization is computed from per-tierStorageUsed{SSD}/StorageCapacity{SSD}.JunctionPath = "/") is detected from returned fields,excluded only where the metric is invalid (OPS-10), tagged elsewhere, and never a
deletion candidate.
missing/failed/empty data → "Not evaluated" with a reason, never a guessed result.
IAM
Least-privilege, read-only. Wired into the shared
cloudformation/devops-agent-skill-policies.yamlvia a newEnableAwsFsxnOperationsReviewtoggle + inline policy (no per-skill IAM file).Note: these actions were not delta-trimmed against
AIDevOpsAgentAccessPolicywith
iam:SimulatePrincipalPolicy(no account access at authoring time) — amaintainer may remove any already covered by the managed policy (e.g.
backup:List*,CloudWatch reads).
sts:GetCallerIdentityis intentionally omitted (needs no IAMpermission).
Testing
and without the skill, across multiple iterations.
evals/: structure, best-practices, and functional(3 scenarios × 3 iterations, with_skill vs without_skill). The functional comparison
favored with_skill on both evaluations.
python3 .github/scripts/validate_skill_evals.py --skill aws-fsxn-operations-reviewpasses locally.
Relates to #118.
By submitting this pull request, I confirm that my contribution is made under the
terms of the Apache License 2.0.