Repository navigation
fix: preserve service errors before cache hooks have a value - #81
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why is this change being made?
When the first DescribeSecret or GetSecretValue request fails, a configured cache hook still receives an uninitialized
Nonevalue. A hook that decodes or looks up its stored object can raise its own exception, hiding the original Secrets Manager error.What is changing?
Use a private sentinel for an unpopulated cache and return no result without invoking the hook in that case. The existing error propagation and retry backoff then preserve the service exception. A successful hook result of
Noneor0remains valid, including when a later refresh fails and the cache serves its previous value.Related Links
Fixes #20.
Testing
KeyError: Nonebefore the fix and now expose ResourceNotFoundException on initial and cached-error reads.Reviewee Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.