Repository navigation
Fix meta-package-check failing on patch-only client bumps - #148
Merged
Merged
Conversation
Alan4506
marked this pull request as ready for review
November 17, 2026 22:43
jonathan343
reviewed
Nov 17, 2026
| def _compatible(version: str) -> str: | ||
| """Return the ``~=`` floor for ``version``: ``<major>.<minor>.0``.""" | ||
| major, minor = version.split(".")[:2] | ||
| return f"{major}.{minor}.0" |
Contributor
There was a problem hiding this comment.
Should we just compare the major and minor instead and not compare the patch at all?
Contributor
There was a problem hiding this comment.
There may be a weird case where we manually move the pin to something other than x.y.0 (e.g. x.y.1) for some reason and we should be okay with that.
I guess in that case, we'd need something to verify the current version if >= patch. Maybe we should compare:
- major and minor are exact
- patch is <= current package version
Collaborator
Author
There was a problem hiding this comment.
Thanks! Fixed in latest commits. The PR title and description have been updated as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meta-package-checkexpects each extra to be exactly<module>~=<client version>, but the release tooling only rewrites an extra when the client's major.minor changes (~=0.13.0already covers0.13.1). So the first release that patch-bumps a client fails the check:extra s3 is ['aws_sdk_s3~=0.13.0'], expected ['aws_sdk_s3~=0.13.1']. #147 hit this in the PR build.This PR relaxes the check. The pin still has to be
<module>~=<version>with the same major.minor as the client, but its patch may be anything up to the client's current patch. Verified locally:0.13.1with extra~=0.13.0or~=0.13.1passes0.13.1with extra~=0.13.2,~=0.12.0, or~=0.14.0fails==pins, extra entries, and non-x.y.zversions fail with a message indicating the expected formBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.