Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
pyproject.tomlgeneration for AWS clients:nameused to be the module name (my_handwritten_model). It's now the normalized form (my-handwritten-model) defined by the packaging name normalization spec. The import name stays the same.Is this breaking?
No. The spec treats
-,_, and.in names as equivalent and says names should be normalized before lookups and comparisons. pip, uv, and PyPI treatmy_handwritten_modelandmy-handwritten-modelas the same project, so existing installs and requirements in either spelling keep working. Imports and built file names don't change either. The only visible difference is thatpip listandpip showprint the dashed name.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.