Repository navigation
Add integration tests for more clients - #136
Conversation
1496661 to
518578d
Compare
518578d to
7ca7899
Compare
7ca7899 to
1cb1d7e
Compare
1cb1d7e to
e7cab44
Compare
e7cab44 to
2ecf829
Compare
b0a3124 to
d07e900
Compare
d07e900 to
da52444
Compare
d24f607 to
fde4495
Compare
|
Sorry, you now have to rebase after we merged #152 |
fde4495 to
bf8cb7a
Compare
| sts: AsyncSTSClient, | ||
| ) -> None: | ||
| """Verifies the environment credential chain signs a request that STS accepts and identifies.""" | ||
| identity = await sts.get_caller_identity(GetCallerIdentityInput()) |
There was a problem hiding this comment.
nit - I think we should start using the await sts.get_caller_identity() instead of await sts.get_caller_identity(GetCallerIdentityInput()) mostly because agents and people will copy what they see in the codebase. The later is cleaner and requires no additional import.
| from .conftest import STSFactory | ||
|
|
||
|
|
||
| async def test_get_caller_identity_resolves_environment_credentials( |
There was a problem hiding this comment.
Sorry if I'm missing something, but I don't get how this is checking that we resolve from environment credentials?
There was a problem hiding this comment.
yeah, this is wrong. I'm removing this test because aws-credentials-sts has the default chain ordering test which covers this.
|
|
||
|
|
||
| @pytest.mark.skip( | ||
| reason="TODO: ClientRequestToken is not auto-filled by smithy-core 0.10; needs the idempotency-token fill from smithy-python #913" |
There was a problem hiding this comment.
this should be good now right? I think there are a few of these we could stop skipping
jonathan343
left a comment
There was a problem hiding this comment.
A few more minor comments
| if marker is None and len(names) < 2: | ||
| pytest.skip("account has fewer than two functions to paginate over") |
There was a problem hiding this comment.
Our account that runs these tests has no lambda functions, so this will always get skipped I think
| token = page.next_token | ||
| if token is None: | ||
| break | ||
| assert pages >= 1 |
There was a problem hiding this comment.
even when there is not pagination, this will always return true since we have a pages += 1 directly after.
| async def test_stream_is_active_on_demand( | ||
| kinesis: AsyncKinesisClient, stream: str | ||
| ) -> None: | ||
| """Verifies the shared stream reports ON_DEMAND mode, ACTIVE status, and its tags.""" |
There was a problem hiding this comment.
nit - tags aren't checked like the docstring says.
| """Verifies the shared stream reports ON_DEMAND mode, ACTIVE status, and its tags.""" | |
| """Verifies the shared stream reports ON_DEMAND mode and ACTIVE status.""" |
| interval=2, | ||
| timeout=60, | ||
| ) | ||
| assert [g.group_id for g in by_tag.security_groups or []] == [security_group] |
There was a problem hiding this comment.
Comment from my robot 🤖:
This
tag:Stagefilter is account-wide. Any leftover or parallel group taggedStage=alphawill break this equality check. Can we add agroup-idfilter, or assertsecurity_groupin ... instead?
Might run into this since multiple builds run in parallel when we open multiple PRs at a similar time.
Add a starter set of integration tests for clients.