Skip to content

ci: run telemetry conformance via shared workflow - #827

Merged
ParidelPooya merged 3 commits into
mainfrom
ci/telemetry-conformance-workflow
Oct 24, 2026
Merged

ParidelPooya merged 3 commits into
mainfrom
ci/telemetry-conformance-workflow

Conversation

@hln33

@hln33 hln33 commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Stack

Stacked on #822. Base branch: feat/conformance-tests-telemetry. Retarget to main and drop the branch filter after the parent merges.

Changes

  • Add .github/workflows/telemetry-conformance-tests.yml. It runs on pull requests, pushes to main, and manual dispatch. It calls the shared telemetry-suite.yml workflow in the conformance repository.
  • Omit setup_command and prepare_command. The CodeBuild runner image provides Python 3.13, which sam build needs. The shared workflow exports PYTHON_SDK_REF and installs pip. So the caller passes only the suite inputs, as the Python OTel caller does.
  • Replace "A caller GitHub workflow is a follow-on." in the handler package README with a ## CI section.

Shared workflow pin

c3d9c992, the head of aws/aws-durable-execution-conformance-tests#150. That commit does two things the Python handler needs:

  1. It exports PYTHON_SDK_REF as a job env, mirroring opentelemetry-suite.yml. src/requirements.txt installs the SDK and exporter from git at ${PYTHON_SDK_REF}.
  2. It installs pip into the shared uv environment, as prepare-otel-example does on conformance main. src/Makefile runs python3 -m pip during sam build.

The pin includes the exact-record golden check from #160. Re-pin to the merge commit after #150 lands.

Verification

  • The workflow file parses with yaml.safe_load.
  • git diff origin/feat/conformance-tests-telemetry --stat shows only the workflow and the README.
  • Cloud run 1 (b84cc0ca, pin 3e4fdaf0): every step through "Recover rolled-back test stack" passed. sam build failed with No module named pip because the shared uv environment had no pip.
  • Cloud run 2 (run 40053972978, head 8385535e, pin 3e4fdaf0 plus caller-side prepare_command for pip and PYTHON_SDK_REF): Deploy succeeded, telemetry-1 PASSED (1 passed, 0 failed, 0 uncovered).
  • Cloud run 3 (run 40055552382, head 1865bf0b, pin 2b41cb37, pip from the shared workflow, PYTHON_SDK_REF still from prepare_command): telemetry-1 PASSED.
  • Cloud run 4 (run 40056925295, head d4190681, pin c3d9c992, no caller-side commands): PYTHON_SDK_REF set by the shared workflow job env, Deploy succeeded, telemetry-1 PASSED (1 passed, 0 failed, 0 uncovered).

@hln33
hln33 force-pushed the ci/telemetry-conformance-workflow branch from b84cc0c to 8385535 Compare October 24, 2026 02:23
@hln33
hln33 added this pull request to stack #828 October 24, 2026 02:31
@hln33
hln33 force-pushed the ci/telemetry-conformance-workflow branch 2 times, most recently from 1865bf0 to d419068 Compare October 24, 2026 03:06
@hln33
hln33 marked this pull request as ready for review October 24, 2026 03:10
@hln33
hln33 deployed to ai-pr-review-runtime October 24, 2026 03:10 — with GitHub Actions Active
@hln33
hln33 deployed to ai-pr-review-runtime October 24, 2026 03:11 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@ParidelPooya

Copy link
Copy Markdown
Contributor

Re-pinned telemetry-suite.yml to d4b7df92, the merge commit of aws/aws-durable-execution-conformance-tests#150, while you are away. #150's branch was deleted after the squash merge, so the old pin no longer resolves. The same stale pin made the Java workflow fail on main with "workflow was not found" (aws/aws-durable-execution-sdk-java#827 fixed it there). Only the pin and its comment changed.

@ParidelPooya
ParidelPooya deployed to ai-pr-review-runtime October 24, 2026 20:08 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@ParidelPooya
ParidelPooya deployed to ai-pr-review-runtime October 24, 2026 20:15 — with GitHub Actions Active
@github-actions

This comment has been minimized.

@ParidelPooya
ParidelPooya force-pushed the ci/telemetry-conformance-workflow branch from 6dc0ce4 to 5a48b12 Compare October 24, 2026 21:39
@ParidelPooya

Copy link
Copy Markdown
Contributor

Rebased onto the new #822 head (c7098ac) after #822 was rebased onto main. Your two commits are unchanged in content.

@github-actions

This comment has been minimized.

Base automatically changed from feat/conformance-tests-telemetry to main October 24, 2026 22:04
hln33 and others added 2 commits October 24, 2026 15:04
The new caller workflow runs the telemetry conformance suite on pull
requests, on pushes to main, and on manual dispatch. It calls the
shared telemetry-suite workflow in the conformance repository at a
pinned commit. The shared workflow exports PYTHON_SDK_REF and installs
pip, as the OpenTelemetry conformance workflow does. So sam build
installs the SDK and exporter from git at the tested commit, and the
caller passes no setup or prepare command. The shared workflow then
deploys the template and validates the telemetry suite.

The README now describes the workflow.
@ParidelPooya
ParidelPooya force-pushed the ci/telemetry-conformance-workflow branch from 5a48b12 to 2de140e Compare October 24, 2026 22:04
@ParidelPooya

Copy link
Copy Markdown
Contributor

Removed the feat/conformance-tests-telemetry branch filter now that #822 is merged and this PR targets main.

@ParidelPooya
ParidelPooya deployed to ai-pr-review-runtime October 24, 2026 22:05 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings in the PR changes. Residual risk: review was limited to static inspection; tests were not run, and the pinned external reusable workflow was unavailable locally.

Reviewed commit b25c020a56b58e3e2a376f035b233dd53fbd7f46. Workflow run

@ParidelPooya
ParidelPooya merged commit a31eaaf into main Oct 24, 2026
23 checks passed
@ParidelPooya
ParidelPooya deleted the ci/telemetry-conformance-workflow branch October 24, 2026 22:27

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — b25c020a Deployed Oct 24, 2026 by ParidelPooya via ai-pr-review / Codex review / Generate Codex review #2369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants