Repository navigation
ci: run telemetry conformance via shared workflow - #827
Conversation
b84cc0c to
8385535
Compare
1865bf0 to
d419068
Compare
This comment has been minimized.
This comment has been minimized.
|
Re-pinned |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6dc0ce4 to
5a48b12
Compare
This comment has been minimized.
This comment has been minimized.
The new caller workflow runs the telemetry conformance suite on pull requests, on pushes to main, and on manual dispatch. It calls the shared telemetry-suite workflow in the conformance repository at a pinned commit. The shared workflow exports PYTHON_SDK_REF and installs pip, as the OpenTelemetry conformance workflow does. So sam build installs the SDK and exporter from git at the tested commit, and the caller passes no setup or prepare command. The shared workflow then deploys the template and validates the telemetry suite. The README now describes the workflow.
5a48b12 to
2de140e
Compare
|
Removed the |
Codex AI reviewNo actionable findings in the PR changes. Residual risk: review was limited to static inspection; tests were not run, and the pinned external reusable workflow was unavailable locally. Reviewed commit |
Stack
Stacked on #822. Base branch:
feat/conformance-tests-telemetry. Retarget tomainand drop the branch filter after the parent merges.Changes
.github/workflows/telemetry-conformance-tests.yml. It runs on pull requests, pushes tomain, and manual dispatch. It calls the sharedtelemetry-suite.ymlworkflow in the conformance repository.setup_commandandprepare_command. The CodeBuild runner image provides Python 3.13, whichsam buildneeds. The shared workflow exportsPYTHON_SDK_REFand installs pip. So the caller passes only the suite inputs, as the Python OTel caller does.## CIsection.Shared workflow pin
c3d9c992, the head of aws/aws-durable-execution-conformance-tests#150. That commit does two things the Python handler needs:PYTHON_SDK_REFas a job env, mirroringopentelemetry-suite.yml.src/requirements.txtinstalls the SDK and exporter from git at${PYTHON_SDK_REF}.prepare-otel-exampledoes on conformancemain.src/Makefilerunspython3 -m pipduringsam build.The pin includes the exact-record golden check from #160. Re-pin to the merge commit after #150 lands.
Verification
yaml.safe_load.git diff origin/feat/conformance-tests-telemetry --statshows only the workflow and the README.b84cc0ca, pin3e4fdaf0): every step through "Recover rolled-back test stack" passed.sam buildfailed withNo module named pipbecause the shared uv environment had no pip.8385535e, pin3e4fdaf0plus caller-sideprepare_commandfor pip andPYTHON_SDK_REF):Deploy succeeded,telemetry-1 PASSED(1 passed, 0 failed, 0 uncovered).1865bf0b, pin2b41cb37, pip from the shared workflow,PYTHON_SDK_REFstill fromprepare_command):telemetry-1 PASSED.d4190681, pinc3d9c992, no caller-side commands):PYTHON_SDK_REFset by the shared workflow job env,Deploy succeeded,telemetry-1 PASSED(1 passed, 0 failed, 0 uncovered).