Skip to content

ci: publish emulator images after pypi packages - #805

Merged
zhongkechen merged 1 commit into
aws:mainfrom
zhongkechen:fix/ecr-after-pypi
Oct 22, 2026
Merged

zhongkechen merged 1 commit into
aws:mainfrom
zhongkechen:fix/ecr-after-pypi

Conversation

@zhongkechen

Copy link
Copy Markdown
Contributor

The testing 1.3.0 image release failed because its Docker build tried to install aws-durable-execution-sdk-python>=2.1.0 about ten seconds before the SDK wheel reached PyPI. Both release workflows started independently on release.published.

Make the ECR workflow reusable and call it only after the PyPI publishing matrix succeeds. Pass the original release tag and the ECR role explicitly, preserving the existing version checks, serialized image releases, and recovery behavior. Failed image jobs can be rerun within the same release run after PyPI publishing has succeeded. Add regression coverage for ordering, tag propagation, and permissions, and run it when either release workflow changes.

Validation:

  • hatch run dev-testing:python -m pytest .github/scripts/tests: 234 passed, including the new regression tests and existing ECR publication/recovery tests. One unrelated failure, test_lintcommit.py::test_subject_uppercase, also reproduces with unchanged files from main.
  • hatch fmt --check .github/scripts/tests/test_release_workflow_dependencies.py: passed.
  • Actionlint 1.7.12: passed with the existing unsupported concurrency.queue diagnostic excluded; the same diagnostic occurs on main.
  • Commit-message validation and git diff --check: passed.

Live PyPI/ECR publishing was not run as part of validation.

@zhongkechen
zhongkechen deployed to ai-pr-review-runtime October 22, 2026 01:23 — with GitHub Actions Active
@zhongkechen
zhongkechen merged commit 8109d9b into aws:main Oct 22, 2026
20 of 21 checks passed

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 9c55cc01 Deployed Oct 22, 2026 by zhongkechen via notify / Generate notification summary #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants