Repository navigation
fix(otel): reject competing telemetry views #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ce0f4d1
0b04265
5301257
8b67dbe
0630650
dfe4d29
ceededc
3f0fc46
f6a8f84
997a44a
cb9efc8
78a14eb
a50e1f5
357921e
68166eb
94a7043
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| [layer] | ||
| sdk-version = "2.0.0" | ||
| sdk-version = "2.1.0" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,13 @@ on: | |
| default: main | ||
| type: string | ||
|
|
||
| # Backend stacks are shared across PRs. Queue whole runs so reusable | ||
| # backend jobs do not displace another PR from their pending slots. | ||
| concurrency: | ||
| group: otel-conformance-tests | ||
| cancel-in-progress: false | ||
| queue: max | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Codex AI review · Finding [P1] Remove the unsupported |
||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
|
|
@@ -59,9 +66,10 @@ jobs: | |
| actions: write | ||
| contents: read | ||
| id-token: write | ||
| uses: aws/aws-durable-execution-conformance-tests/.github/workflows/opentelemetry-orchestrator.yml@a628f5589bbf067a441696c792ab3023c0d0899b | ||
| uses: aws/aws-durable-execution-conformance-tests/.github/workflows/opentelemetry-orchestrator.yml@a66037abbbfa55fde97f714e30f0bc262edefd63 | ||
| with: | ||
| language: python | ||
| runs_on: codebuild-github-actions-runner-${{ github.run_id }}-${{ github.run_attempt }} | ||
| resource_prefix: p | ||
| sdk_repository: aws/aws-durable-execution-sdk-python | ||
| sdk_ref: ${{ github.event.pull_request.head.sha || github.sha }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # SPDX-FileCopyrightText: 2025-present Amazon.com, Inc. or its affiliates. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| __version__ = "1.0.0" | ||
| __version__ = "1.1.0" |
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked against the current official Actions workflow schema:
concurrency-mappingincludesqueue, with allowed valuessingleandmax. Both workflow-level and job-level concurrency use that mapping.Runtime validation agrees: Cloud tests and Conformance Tests succeeded on the reviewed commit
68166eb; all six OTel test jobs also succeeded with these same concurrency declarations before the subsequent JS harness-only commit. These workflows are therefore accepted and executing. Keepingqueue: maxwithcancel-in-progress: falsepreserves pending runs without canceling the active tests.