Repository navigation
fix: isolate incompatible OpenTelemetry API linkage failures - #780
Merged
Merged
Conversation
zhongkechen
marked this pull request as ready for review
October 6, 2026 23:14
zhongkechen
added this pull request to stack #783
October 6, 2026 23:37
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 7, 2026 00:57 — with
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 7, 2026 02:58 — with
GitHub Actions
Error
Contributor
Codex AI reviewNo actionable findings. Residual risk: runtime compatibility and CI workflow behavior were assessed statically and not executed, per review constraints. Reviewed commit |
nvasiu
approved these changes
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes #763. An older visible OpenTelemetry API can lack
GlobalOpenTelemetry.isSet()orgetOrNoop(). The resultingNoSuchMethodErrorpreviously escaped plugin dispatch and failed the customer invocation. The plugin now checks those APIs before global-provider binding and reports incompatible dependencies without installing a no-op global. Runtime hook dispatch also isolatesLinkageError, so healthy plugins and the handler continue.This is an independently mergeable 2.x fix for work item 7. Public APIs, constructors, instance lifetimes, dependency versions, and provider configuration validation are unchanged. Fatal JVM errors and
ThreadDeathretain their existing propagation behavior. Align incompatible dependencies to restore telemetry; containment does not make an unsupported API export spans.Merge this PR into main first. The separate major factory migration in #782 is stacked on this branch; after this PR merges, update #782 from main and retarget it to main. Do not merge #782 into this 2.x branch.
The CI callers preserve their existing serial shared-resource groups and retain pending runs. Java 17 Build now runs a required installed-artifact compatibility matrix; dependency-resolution and probe failures fail CI rather than skipping coverage.
Validation
mvn -B clean verify: 2,171 tests, 31 existing skips, zero failures/errors, including main's CodeBuild and test-environment changes.PluginRunnerpublic signatures match the 2.x main baseline. No production POM or dependency-floor changes.Checklist