test: relax child context replay time thresholds - #660
Conversation
Codex AI reviewNo actionable findings. The PR only relaxes cloud replay-time thresholds to match neighboring performance tests. Residual risk is limited to normal environment-dependent timing variability. Reviewed commit |
Claude AI reviewThis PR is a minimal, test-only change: it raises the replay-time budgets in Verified:
No correctness, API compatibility, replay-semantics, concurrency, or logging concerns apply. Residual test risk: widening the replay-time budget by 10 ms in both cases slightly reduces this test's sensitivity to small, incremental replay-performance regressions in child contexts, since regressions that stay under the new looser ceiling would no longer be caught. This is an acceptable, deliberate trade-off given the observed timing flakiness at the tighter bound ( Reviewed commit |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Failing E2E job: https://github.com/aws/aws-durable-execution-sdk-java/actions/runs/33020522022/job/98349518389
Description
The Java 21 E2E job completed all 500 child contexts successfully, but the best replay time across three attempts was exactly 20 ms. The test required the value to be strictly less than 20 ms, so the performance assertion failed even though the result and operation-tracking assertions passed.
Raise the replay-time budgets for 100 and 500 child contexts from 10/20 ms to 20/30 ms. These values match the neighboring async-step performance tests and cover timing variation already observed across Java 21 and Java 25 runs.
Demo/Screenshots
Not applicable; this is a test-threshold adjustment.
Checklist
Testing
mvn spotless:applymvn -pl examples -am test -Dtest=ManyAsyncChildContextExampleTest -Dsurefire.failIfNoSpecifiedTests=falseUnit Tests
No new unit tests were needed because the change only adjusts existing cloud performance-test inputs. The focused local example test suite passed.
Integration Tests
No new integration tests were added. The affected cloud E2E test will run in this PR's workflow matrix.
Examples
No new example was added; the existing
ManyAsyncChildContextExampleis unchanged.