test(otel): add virtual context conformance handler - #637
Conversation
| Type: AWS::Serverless::Function | ||
| TestingMetadata: | ||
| TestDescription: | ||
| - otel-invocation-20 |
There was a problem hiding this comment.
Codex AI review
[P2] Advance the conformance suite pin
Normal PR/push runs still pass the fixed 0f0b5b... ref from .github/workflows/otel-conformance-tests.yml. Merging the prerequisite requirement does not update that SHA, so otel-*-20 will not be selected and this change receives no behavioral coverage. Update the workflow's uses and fallback conformance_test_ref SHAs to the merged commit containing requirement 20.
Codex AI reviewOne CI coverage gap remains; the handler and SAM wiring otherwise match existing patterns. Reviewed commit |
Claude AI reviewNo actionable findings. This PR adds a single conformance handler (
Considered and discarded: (1) the class javadoc naming only Residual test risk: correctness of the virtual-context telemetry is validated only by the paired conformance-repo scenarios and deployed-Lambda cloud runs (per the PR description), not by any in-repo unit/integration test. If the virtual child-context replay/telemetry behavior regresses in the SDK, nothing in this repo's automated test suite would catch it. Reviewed commit |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Related conformance requirement: aws/aws-durable-execution-conformance-tests#96
Merge order: merge the shared conformance requirement PR first, then this Java SDK handler PR.
Description
Adds the Java SDK-owned
Otel20VirtualContexthandler for the new virtual child-context OTel scenario. The SAM template maps the handler to bothotel-invocation-20andotel-execution-20, selecting execution-view telemetry throughOTEL_PLUGIN_MODE.Demo/Screenshots
Not applicable; this change adds deployed conformance-test handlers.
Checklist
Testing
Unit Tests
No new unit test was added because this is a standalone conformance handler and template mapping with no new SDK behavior. The handler was compiled as part of the module package build.
Integration Tests
The paired end-to-end requirements are added in aws/aws-durable-execution-conformance-tests#96 and will run through the OTel conformance workflow. Locally, the standalone module packaged successfully with
JAVA_SDK_VERSION=2.1.1-SNAPSHOT.Examples
Added
Otel20VirtualContextand invocation/execution SAM mappings.