docs: Fixed wrong package name and wrapper function#178
Conversation
Wrong package name and wrapper function
Wrong package name and wrapper function
Wrong package name and wrapper function
TrickSumo
changed the title
File not required here
TrickSumo
changed the title
yaythomas
left a comment
yaythomas
left a comment
There was a problem hiding this comment.
Thanks for catching durableExecution → withDurableExecution, that rename is right (with-durable-execution.ts:354).
The package-name fix has a typo — it's @aws/durable-execution-sdk-js (scoped npm package, forward slash between @aws and durable-execution-sdk-js), not @aws-durable-execution-sdk-js. The latter isn't a valid npm specifier and won't resolve. Verified against the SDK's package.json; every other TS example in this repo uses @aws/durable-execution-sdk-js. Suggestion blocks on each file below — one-click apply.
Also — the examples/typescript/getting-started/custom-boto3-client.ts deletion is outside this PR's stated scope ("wrong package name and wrapper function in examples/typescript/operations/invoke folder"), and there are ~480 other // Coming soon... stub files in examples/ that would need the same treatment if we're removing placeholder files. Could you revert the deletion, or open a separate PR that handles them as a set?
| durableExecution, | ||
| } from "aws-durable-execution-sdk-js"; | ||
| withDurableExecution, | ||
| } from "@aws-durable-execution-sdk-js"; |
There was a problem hiding this comment.
| } from "@aws-durable-execution-sdk-js"; | |
| } from "@aws/durable-execution-sdk-js"; |
yaythomas
left a comment
yaythomas
left a comment
There was a problem hiding this comment.
approved w inline changes
2 participants
Issue
Wrong package name and wrapper function in examples/typescript/operations/invoke folder.