fix: support pool_pre_ping in SQLAlchemy ORM MySQL dialect#1245
Open
sudosubin wants to merge 1 commit into
Open
fix: support pool_pre_ping in SQLAlchemy ORM MySQL dialect#1245sudosubin wants to merge 1 commit into
sudosubin wants to merge 1 commit into
Conversation
Signed-off-by: sudosubin <sudosubin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
pool_pre_ping=Truefor the SQLAlchemy ORM MySQL dialect. SQLAlchemy passes the DBAPI connection todo_ping, which here is anAwsWrapperConnection. The inheriteddo_pingcallsdbapi_connection.ping(), butAwsWrapperConnectiondoes not exposeping(), so every pool checkout raised'AwsWrapperConnection' object has no attribute 'ping'.This overrides
do_pingto ping the wrapped driver connection (target_connection) instead. A dead connection raises a nativemysql.connectorerror, which SQLAlchemy cannot classify as a disconnect becauseimport_dbapireports the wrapper module as the DBAPI (its exception hierarchy is unrelated tomysql.connector's), sodo_pingcatches it and returnsFalse, letting the pool invalidate and reconnect.Unit tests are added for the live and dead connection paths.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.