fix: don't signal onComplete when a chunk is fully consumed by the ra… - #523
Open
sharmabikram wants to merge 1 commit into
Open
sharmabikram wants to merge 1 commit into
sharmabikram wants to merge 1 commit into
Conversation
| // rather than signaling completion. | ||
| numBytesToSkip -= buf.length; | ||
| wrappedSubscriber.onComplete(); | ||
| return; |
Contributor
There was a problem hiding this comment.
I am pretty sure we still need to signal something to the subscriber. I don't know what it would be but it feels really weird that we would go from telling the subscriber "done" to not telling the subscriber anything.
Contributor
There was a problem hiding this comment.
Maybe signal wrappedSubscriber's onNext with an empty buffer? Since that's really what's going on here
…nge skip AdjustedRangeSubscriber called onComplete (and fell through to an NPE) when numBytesToSkip exceeded a chunk, so a small first chunk ended ranged GETs with an empty stream. Consume the chunk toward the skip and wait for the next one instead. Fixes #517.
sharmabikram
force-pushed
the
shbikram/adjustedrange-premature-oncomplete
branch
from
September 26, 2026 23:03
f9fb658 to
4bb8003
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume the chunk toward the skip and return instead of completing; the real onComplete still fires when upstream ends. Changed > to >= so a chunk equal to the skip is also fully consumed. Fixes #517.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: