test(cognito-users): cover directory guards and pagination failures - #449
Draft
ivancasco wants to merge 1 commit into
Draft
test(cognito-users): cover directory guards and pagination failures#449ivancasco wants to merge 1 commit into
ivancasco wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #172.
Adds missing Cognito directory unit coverage for OPTIONS, unsupported methods, missing identity and pool configuration, attribute projection/defaults, empty results, exact pagination tokens, and SDK failures on both the first and later pages. Tests also isolate SSO configuration and restore logging spies.
The current branch already uses ESM, centralized workspace test dependencies, and esbuild-only Lambda packaging, so this change preserves those conventions and existing admin/SSO behavior.
Validation (isolated PR worktree, commit
5aa1149):p/javascriptandp/typescript: no findings across 578 files. The broad scan reported partial parsing in seven existing frontend files and default exclusions; an explicit scan of the changed Cognito test file had no findings or parsing errors.Validation caveats:
brace-expansion,js-yaml,hono, andqs). Frontend production audit reports no vulnerabilities. Dependency remediation is outside this test-only patch.