-
Notifications
You must be signed in to change notification settings - Fork 46
fix(deps): bump fast-uri past 4 HIGH advisories in both lockfiles #848
Copy link
Copy link
Closed
Labels
approvedWhen an issue has been approved and readyWhen an issue has been approved and readybugSomething isn't workingSomething isn't workingci-cdBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsdependenciesPull requests that update a dependency filePull requests that update a dependency filesecurityCedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVECedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVEv1Version 1Version 1
Description
Activity
Metadata
Metadata
Assignees
Labels
approvedWhen an issue has been approved and readyWhen an issue has been approved and readybugSomething isn't workingSomething isn't workingci-cdBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowsdependenciesPull requests that update a dependency filePull requests that update a dependency filesecurityCedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVECedar/HITL, IAM least-privilege, secrets, PII/DLP, guardrails, supply-chain/CVEv1Version 1Version 1
What happened
security-prfails onmainand therefore on every PR branched from or merged with it. osv-scanner reports 8 findings across two lockfiles, all one package:Four distinct HIGH advisories, each reported once per lockfile:
fast-uriis transitive (viaajv), and pins already exist in both places — both at^3.1.5, which resolves to the vulnerable version:package.json→resolutionsintegrations/jira-forge-app/package.json→overridesWhy it needs both places
integrations/jira-forge-appis a standalone npm project outside the yarn workspaces, so a rootresolutionsbump does not reach it — the pin has to be mirrored and itspackage-lock.jsonre-locked separately. This is the casecheck:transitive-pin-syncexists for (#712).Fix
Bump both pins to
^3.1.6and re-resolve both lockfiles — no source change:Both resolve to
3.1.7. Verified locally:mise run security:depsexits 0, andmise run drift-preventionreportscheck-transitive-pin-sync: OK — 4 shared pin(s) in sync.Other information
Same shape as #637/#636 (lockfile-only re-resolve to clear OSV advisories). Filing this as the tracking issue for that work rather than folding the bump into an unrelated in-flight PR — it currently blocks CI on #705, which did not introduce it.