fix: corrections for "getting-started" module - #1933
Open
parth-pandit wants to merge 25 commits into
Open
parth-pandit wants to merge 25 commits into
parth-pandit wants to merge 25 commits into
Conversation
… on snapshot builds
- Clarify that paths focus on essential labs for specific roles - Add mention of managed EKS capabilities path option - Update fast-path-options.png diagram to reflect current offerings - Improve documentation accuracy for learning path selection
- Updated translations for: ja - Generated from commit: 5595952 - Workflow run: 26311013587
- Updated translations for: ja - Generated from commit: 2be9ad9 - Workflow run: 26415493903
- Updated translations for: ja - Generated from commit: 4a03d6c - Workflow run: 26917762275
- Updated translations for: ja - Generated from commit: 6ce6106 - Workflow run: 27023854532
- Updated translations for: ja - Generated from commit: 18a110c - Workflow run: 29603462904
- Updated translations for: ja - Generated from commit: 3fff201 - Workflow run: 29607121255
- Updated translations for: ja - Generated from commit: 31ce1bb - Workflow run: 30546068962
- Updated translations for: ja - Generated from commit: d8f1b25 - Workflow run: 30557099423
- Updated translations for: ja - Generated from commit: bb1b300 - Workflow run: 30664504258
- Updated translations for: ja - Generated from commit: 8a555c0 - Workflow run: 32186137541
- Updated translations for: ja - Generated from commit: b59d0b8 - Workflow run: 32190377509
- Updated translations for: ja - Generated from commit: 8491842 - Workflow run: 32409752345
- Updated translations for: ja - Generated from commit: 385c620 - Workflow run: 32514887536
- Updated translations for: ja - Generated from commit: 7e616cb - Workflow run: 32797930568
- Updated translations for: ja - Generated from commit: 8a5de39 - Workflow run: 32854010614
- Updated translations for: ja - Generated from commit: b8d8d27 - Workflow run: 32865261581
- Updated translations for: ja - Generated from commit: 58b5da9 - Workflow run: 34404141332
- Updated translations for: ja - Generated from commit: 5fbe0b0 - Workflow run: 34507500484
- Updated translations for: ja - Generated from commit: 28d7716 - Workflow run: 34513127076
The pre-provisioning build is not permitted to create an IAM Identity Center instance in a Workshop Studio account. The team stack now creates it as a CloudFormation resource and passes the ARN in as idc_instance_arn. When that ARN is set, skip creation and adopt the instance. The adopt path that already existed is not enough on its own: it returns before relaxing MFA enforcement, on the reasoning that an instance we merely found is not ours to reconfigure. That is right for an instance somebody else set up, and wrong for this one, which exists only for this event. Leaving MFA enforced would put a device-registration prompt in front of the forced password change activate-user.py drives, so activation would fail and participants would get no working sign-in -- while provisioning still reported success. Both ours-to-configure paths now share one relax_mfa_enforcement step, and the found-instance path still skips it. Creating the user, group and membership is unaffected, so that stays here. An empty ARN keeps today's create-or-adopt behaviour for self-service and CI runs, where nothing has made an instance and the module is free to create one. Teardown leaves a stack-owned instance to CloudFormation.
… content - Add example output for system nodepool in kubectl get nodes command - Fix grammar: "all of resources" to "all resources" - Fix indentation alignment for operator link in JSX code block - Add new "Capability Essentials" learning path option to fastpath navigation - Update namespace output example to reflect current cluster state with additional namespaces
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the lab instructions to align some command outputs to the actual ones, adds missing module links, and have minor grammar corrections.
Which issue(s) this PR fixes:
Fixes #
Quality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.