Skip to content

test(amplify-category-auth): generate ephemeral EC key at runtime instead of committed key literal #14985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Simone319 wants to merge 1 commit into
base: dev
Choose a base branch
from
+12 −8
Open

test(amplify-category-auth): generate ephemeral EC key at runtime instead of committed key literal #14985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions ...th/src/__tests__/provider-utils/awscloudformation/utils/extract-apple-private-key.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
import * as crypto from 'crypto';
import { extractApplePrivateKey } from '../../../../provider-utils/awscloudformation/utils/extract-apple-private-key';

describe('When extracting apple private key...', () => {
const expectedOutput =
'MIGTAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBHkwdwIBAQQgIltgNsTgTfSzUadYiCS0VYtDDMFln/J8i1yJsSIw5g+gCgYIKoZIzj0DAQehRANCAASI8E0L/DhR/mIfTT07v3VwQu6q8I76lgn7kFhT0HvWoLuHKGQFcFkXXCgztgBrprzd419mUChAnKE6y89bWcNw';
// The key is generated at runtime so that no static private-key-shaped literal is
// committed to source (Mirador acat-bosco/rsa-private-key false-positive). P-256 is
// the curve Sign in with Apple uses (ES256).
const { privateKey: pem } = crypto.generateKeyPairSync('ec', {
namedCurve: 'prime256v1',
privateKeyEncoding: { type: 'pkcs8', format: 'pem' },
publicKeyEncoding: { type: 'spki', format: 'pem' },
});

const expectedOutput = crypto.createPrivateKey(pem).export({ type: 'pkcs8', format: 'der' }).toString('base64');

it('it should remove new lines and space and comments', () => {
const input = `-----BEGIN PRIVATE KEY-----
MIGTAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBHkwdwIBAQQgIltgNsTgTfSzUadY
iCS0VYtDDMFln/J8i1yJsSIw5g+gCgYIKoZIzj0DAQehRANCAASI8E0L/DhR/mIf
TT07v3VwQu6q8I76lgn7kFhT0HvWoLuHKGQFcFkXXCgztgBrprzd419mUChAnKE6
y89bWcNw
-----END PRIVATE KEY-----`;
const input = pem;
expect(extractApplePrivateKey(input)).toEqual(expectedOutput);
});

Expand Down
Loading