Repository navigation
Reject assigning a string to an attribute index - #34
Merged
Merged
Conversation
AttrsList.__setitem__ with an integer index treated a string value as a (key, value) pair, so attrs[0] = "confirm" renamed the first attribute to "c" and set its value to "o". Raise TypeError instead, and describe the accepted combinations with overloads, so that type checkers report it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttrsList.__setitem__with an integer index treated a string value as a(key, value)pair, soattrs[0] = "confirm"renamed the first attribute to"c"and set its value to"o".Raise
TypeErrorinstead, and describe the accepted combinations with overloads, so that type checkers report it too.