Repository navigation
Check types in CI - #33
Merged
Merged
Conversation
Add a typecheck job to the test workflow, so that type errors don't come back: it runs mypy in strict mode and pyright on the package, targeting the oldest supported Python version, and mypy's stubtest, which checks that the _rustlib stubs match the compiled module. Add a typecheck dependency group with mypy and pyright, whose versions uv.lock pins (which matters for type checkers in particular, since new versions can find new errors), and a test-types Makefile target that runs the same checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
typecheckjob to thetestworkflow, so that type errors don't come back: it runs mypy in strict mode and pyright on the package, targeting the oldest supported Python version, and mypy's stubtest, which checks that the_rustlibstubs match the compiled module.Add a
typecheckdependency group with mypy and pyright, whose versionsuv.lockpins (which matters for type checkers in particular, since new versions can find new errors), and atest-typesMakefiletarget that runs the same checks.