Repository navigation
Commit Cargo.lock - #31
Merged
Merged
Conversation
Without a lockfile, every build resolves the latest compatible versions of the Rust dependencies at that moment, so a new release of any of them can change or break a build with no change to this repository, and a release can be built from different dependencies than CI tested. Cargo recommends committing Cargo.lock for packages like this one that build a binary artifact (here, the Python extension module). Generate it with cargo generate-lockfile, and build the release wheels with --locked, so that they fail rather than silently updating it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
force-pushed
the
cargo-lock
branch
2 times, most recently
from
October 6, 2026 11:31
af4ada9 to
64c796b
Compare
uv pip install --group ci resolved the latest versions of the test dependencies rather than using uv.lock, so CI didn't test the locked versions and didn't notice when uv.lock fell out of date with pyproject.toml. Install them with uv sync --locked, and build with maturin develop --locked, so that CI fails if uv.lock or Cargo.lock needs updating. uv sync creates the virtual environment itself, with the requested Python, and uv run runs commands in it, so drop the uv venv command and the PATH and PYO3_PYTHON settings (maturin builds for the virtual environment's Python). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a lockfile, every build resolves the latest compatible versions of the Rust dependencies at that moment, so a new release of any of them can change or break a build with no change to this repository, and a release can be built from different dependencies than CI tested. Cargo recommends committing
Cargo.lockfor packages like this one that build a binary artifact (here, the Python extension module).Generate it with
cargo generate-lockfile, and build the release wheels with--locked, so that they fail rather than silently updating it.