Skip to content

Fix the module name of HtmlOptions and XmlOptions #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awolverp merged 2 commits into from
Oct 6, 2026
Merged

Fix the module name of HtmlOptions and XmlOptions #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc5c9d
Fix the module name of HtmlOptions and XmlOptions
andersk Oct 5, 2026
4c3b217
Merge branch 'master' into options-module-name
awolverp Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/tests/test_rustlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,13 @@ def test_serialize():
assert rl.serialize(dom.root(), 0, is_html=False) == b"<hello>Ali</hello>"


def test_class_modules():
classes = [value for value in vars(rl).values() if isinstance(value, type)]
assert rl.HtmlOptions in classes

for cls in classes:
assert cls.__module__ == "markupever._rustlib", cls

def test_iter_submodule():
import markupever._rustlib.iter

Expand Down
4 changes: 2 additions & 2 deletions src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
///
/// # Note
/// this type is immutable.
#[pyo3::pyclass(name = "HtmlOptions", module = "markupselect._rustlib", frozen)]
#[pyo3::pyclass(name = "HtmlOptions", module = "markupever._rustlib", frozen)]
pub struct PyHtmlOptions {
exact_errors: bool,
discard_bom: bool,
Expand Down Expand Up @@ -139,7 +139,7 @@ impl PyHtmlOptions {
}
}

#[pyo3::pyclass(name = "XmlOptions", module = "markupselect._rustlib", frozen)]
#[pyo3::pyclass(name = "XmlOptions", module = "markupever._rustlib", frozen)]
pub struct PyXmlOptions {
exact_errors: bool,
discard_bom: bool,
Expand Down
Loading