Repository navigation
Don't escape raw text when serializing only an element's children - #25
Merged
Merged
Conversation
With include_self=False, serialize passed TraversalScope::ChildrenOnly
without the parent element's name. html5ever's serializer uses that
name to decide whether the children are raw text, so the contents of
<script> and <style> were escaped: "if (a < b) {}" serialized as
"if (a < b) {}", which changes the script.
Pass the element's name when serializing its children.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
A fragment parsed with fragment_context is parsed as the contents of
the context element, but its nodes become the children of the tree's
document node, which serialize escapes as usual. So text parsed in a
raw text context didn't round-trip:
parse('console.log("<br>")', HtmlOptions(fragment_context="script"))
serialized as 'console.log("<br>")', which parses back to
different text.
Remember the context element in IDTreeDOM, and serialize the document
node of a fragment as if its children were the children of the context
element, as html5ever's serializer allows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
include_self=False,serializepassedTraversalScope::ChildrenOnlywithout the parent element's name. html5ever's serializer uses that name to decide whether the children are raw text, so the contents of<script>and<style>were escaped:"if (a < b) {}"serialized as"if (a < b) {}", which changes the script.Pass the element's name when serializing its children.
A fragment parsed with
fragment_contextis parsed as the contents of the context element, but its nodes become the children of the tree's document node, which serialize escapes as usual. So text parsed in a raw text context didn't round-trip:parse('console.log("<br>")', HtmlOptions(fragment_context="script"))serialized as
'console.log("<br>")', which parses back to different text.Remember the context element in
IDTreeDOM, and serialize the document node of a fragment as if its children were the children of the context element, as html5ever's serializer allows.