Repository navigation
fix: use from_borrowed_ptr for Py_None to prevent invalid DECREF - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound::from_owned_ptrwas used onPy_None(). This incorrectly takes ownership of the immortalNonesingleton.When the
Boundis dropped it issues aPy_DECREF. On some Python versions / builds this causes Python to attempt to deallocateNoneand panic.Noneis immortal on CPython 3.12+, but the incorrect ownership is still wrong and can panic on other builds or older Python.Fix
Replace
from_owned_ptrwithfrom_borrowed_ptrso theINCREF/DECREFpair is balanced.