Skip to content

fix: preserve Godot virtual callbacks in unused-code checks - #7

Merged
nicodes merged 1 commit into
mainfrom
fix/protected-godot-callbacks
Sep 6, 2026
Merged

nicodes merged 1 commit into
mainfrom
fix/protected-godot-callbacks

Conversation

@nicodes

@nicodes nicodes commented Sep 6, 2026 •

Copy link
Copy Markdown
Member

Godot invokes virtual callbacks such as _get_configuration_warnings and _get_property_list without script call sites. The usage scanner already recognizes these callbacks, but the unused-code checker kept a shorter duplicate list and could report/remove them.

Use the existing shared callback predicate for both paths. Regression tests cover actual callback analysis, ordinary helper names, and non-function entities. go test ./... passes, and the built linter clears the reproduced callback failure in Revik without relaxing its lint configuration.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@nicodes
nicodes merged commit 035d162 into main Sep 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant