fix: preserve Godot virtual callbacks in unused-code checks - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Godot invokes virtual callbacks such as
_get_configuration_warningsand_get_property_listwithout script call sites. The usage scanner already recognizes these callbacks, but the unused-code checker kept a shorter duplicate list and could report/remove them.Use the existing shared callback predicate for both paths. Regression tests cover actual callback analysis, ordinary helper names, and non-function entities.
go test ./...passes, and the built linter clears the reproduced callback failure in Revik without relaxing its lint configuration.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.