fix: ship stable route result UID and verify package integrity - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Related to aviorstudio/fieldsofrevik#173 (source package correction only; consumer adoption remains separate).
src/core/route_result.gd.uid, genuinely generated by the checksummed official Godot 4.7.2 editor in a fresh isolated project:uid://7xotdfdrekmp..gdUID completeness from actual source scripts independently of manifest sidecar entries; reject malformed and duplicate shipped-script UIDs.Local validation
Pinned archive SHA-512 values match
.github/actions/setup-godot/action.yml; actual editor and used Web template bytes match archive members. Engine:4.7.2.stable.official.ed1daf0bf. Isolated HOME/config/cache/tmp used.python3 tests/package_contract_test.py -v: 9 passed, including six UID/non-UID installed mutations and three archive mutations, each restored../tests/test.sh: passed, including package controls, six runner negative controls/restored positive, hosted router behavior../tests/package_lifecycle_test.sh: passed, four editor restarts, consumer ownership preserved, 13 complete installed-tree equality checks, native smoke and Web export.git diff --check: passed.Tested ZIP SHA-256:
133003d6fa9085902e529344959409873d84af914e130f1616caf10329c2af2b(37 files).Installed-tree path/byte digest:
6b566c6a8b5dd75ad2769bae9936f82500c94cfb62233f5285f7298d5db755d2; actual installed fixtures matched every path and byte.Failures, restoration and remaining gates
web_nothreads_debug.zip/web_nothreads_release.zip. Extracted those exact members from the already checksum-verified official template archive; reran the complete lifecycle on fresh single-install fixtures and unchanged ZIP successfully. No source/preset/allowlist workaround.--no-sandboxonly for the trusted, exact local export at127.0.0.1, with isolated profile/HOME and no accounts, credentials or external navigation. Runtime emittedPASS gd-router web_package_smoke reachable=1exactly once, console reported zero errors/warnings, canvas and exact local URL were asserted, and a screenshot was retained. Named browser and owned server were closed. This is a local security-qualified smoke, not a production sandbox change. Two auxiliary probe mistakes (absent status element and CLI callback signature) were preserved and corrected; they were not application runtime errors.Local detailed logs and provenance retained at
/tmp/router-173-source-evidence/(including initial failures and successful restoration).