Make route navigation transactional - #12
Merged
Merged
Conversation
Member
Author
|
Correction — originating issue aviorstudio/fieldsofrevik#152: the initially published screenshot URL contained an unverified full commit suffix. It is corrected below to the verified exact head Self-verification evidence — exact head
|
| Acceptance criterion | Exact-head evidence |
|---|---|
| Transactional route/history commit and failed-back rollback | tests/hosted_router_test.gd: successful mounts commit route/params/history; missing-scene back returns FAILED and preserves route, params, and history. ./tests/test.sh passed. |
| Latest-wins explicit supersession (D03) and request generations | Overlapping deferred-host and real threaded-resource tests assert prior result SUPERSEDED, cancellation, stale completion rejection, and latest-only commit. |
| Transition/host lifecycle cleanup | Shared-transition overlap, invalid transition partial disposal, host destruction failure, externally freed previous scene, and abandoned threaded-load draining all passed without the new ObjectDB leak. |
| Repeated/concurrent regression coverage | Repeated push/replace/back and concurrent resource/transition cases passed in the canonical suite. |
| Exact assembled package/install lifecycle | ./scripts/package_addon.py and tests/package_lifecycle_test.sh passed: 36 manifest files, ZIP SHA-256 5f850d789c5668a293d7d291d07e7a43932f947eeead03cf14da7798325b9a2a, installed-tree SHA-256 3d0e949c9000529b1960e1a2d2c8fb6c301699c4e28a8c4893e4b967f65e8ed1, enable/restart/smoke/Web export/disable/restart, consumer-owned autoload preserved. |
| Browser path | Playwright loaded the exact packaged Web export, observed PASS gd-router web_package_smoke reachable=1, and reported 0 console errors. Visual UI behavior itself is unchanged. |
| Exact-head CI | CI run 34718991598 completed successfully for the exact head. |
Native stack linking remains blocked because gh stack link 11 12 is currently rejected by the caller account GraphQL quota; the PR base is correctly chained to a12-truthful-gates. No review requested or awaited under Team No Review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Part of aviorstudio/fieldsofrevik#152
Local acceptance evidence
4.7.2.stable.official.ed1daf0bfGODOT_BIN=/tmp/opencode/godot-4.7.2/Godot_v4.7.2-stable_linux.x86_64 ./tests/test.sh— PASS, including six demonstrated negative controls and transactional routing regressions./scripts/package_addon.py— PASS; ZIP SHA-2565f850d789c5668a293d7d291d07e7a43932f947eeead03cf14da7798325b9a2a; installed tree SHA-2563d0e949c9000529b1960e1a2d2c8fb6c301699c4e28a8c4893e4b967f65e8ed1; 36 filestests/package_lifecycle_test.sh— PASS; exact ZIP enable/restart/smoke/Web export/disable/restart and consumer-owned autoload preservation0.1.18against the packaged Web export —PASS gd-router web_package_smoke reachable=1, 0 console errorsNo review requested: Team No Review workstream; coder-owned verification applies.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.