Isolate browser bridge cleanup - #16
Merged
Merged
Conversation
nicodes
added this pull request to stack #17
September 13, 2026 01:07
nicodes
force-pushed
the
issue-148-diagnostics-policy
branch
from
September 13, 2026 02:09
8582a78 to
abc548b
Compare
nicodes
force-pushed
the
issue-148-diagnostics-policy
branch
from
September 13, 2026 02:10
abc548b to
a8b89a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production diagnostics policy and browser-verification layer for https://github.com/aviorstudio/fieldsofrevik/issues/148. Native stack #17; depends on #15.
Acceptance evidence
Source head after the native-stack replay onto merged #15:
a8b89a1f705ccca82cea27087600ad5b82ad49ba(tree-identical to pre-replay8582a7898676f88eff7bf4e9d683344de30e3e67).playwright-cliobserved nogodotElements,godotEvents,godotTestState, or owner global despite enabled/test-mode settings.gd_playwright_diagnostics. Exact-head CI release-export identities were distinct: ordinary62aa0cf7037d062be4d53058f0c00146a1c25807dab0ea84e7379013d62cbcfb; diagnostic4ef999af717bb25da97c867833baa25a6754ec80ee89a00b38409da9097bc757.start_button/route, rejected undeclared entries and nestedtoken, and rejected non-JSON values in focused Godot tests. This is bounded validation, not a confidentiality guarantee.playwright-cli0.1.18/Playwright Chromium, export both release artifacts from the exact ZIP, run browser assertions, and upload screenshots/identities. Replayed exact-head CI: PASS — https://github.com/aviorstudio/gd-playwright/actions/runs/34732370313; downloaded CI screenshots and identities were personally inspected.Ordinary release artifact
Diagnostic release artifact
Local verification
1.24.13:go test ./...— PASS.1.2.23:bun test— 5 tests, 14 assertions, PASS.4.7.2: four addon scripts, payload policy tests, and 8 runner controls — PASS.43b086fe617324dae171336b13a552affa496aa5a8ea1016ba0d22e3f44a8969.2b665e540e9f5069088e0c15ca637921e8c3ded30c8b0cd0e1611c9adda58ba3.playwright-cli0.1.18, ordinary and diagnostic Godot 4.7.2 release exports — PASS; named session closed.1.7.7, ShellCheck0.11.0, andgit diff --check— PASS.No reviewer is requested under Team No Review.