Fix release package checksum path - #13
Merged
Merged
Conversation
Isolate and bound network transports
Member
Author
Exact-head acceptance evidenceOriginating issue: https://github.com/aviorstudio/fieldsofrevik/issues/145
All pre-merge gates for this correction pass. Release and GDAM verification remain post-merge gates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the deployment blocker found while delivering aviorstudio/fieldsofrevik#145.
Corrections
Originating issue: https://github.com/aviorstudio/fieldsofrevik/issues/145.
web_fetch_bridge_module_test.gdand passed 10/10 reachable sentinels.Failure control
Release run https://github.com/aviorstudio/gd-network/actions/runs/34741705851 passed the exact release test job, then failed in the publish job because
sha256sumread the checksum manifest fromdist/while resolving its listed ZIP filename from the repository root. GitHub Release and GDAM publish did not run.Change
Run strict checksum verification through
scripts/verify_package_checksum.shfrom both the release workflow andtests/package_test.sh. CI reaches the same assertion that gates publication.Self-verification
34742069189: PASS at652492faa65a3dbf7bcfad6275507d931a3867fb.10313230687: strict ZIP checksum PASS (c0d1acaabd09e146837175c4badd486e91b88481c7bd0b32020e37b4f9882866); closed 21-file manifest and installed-tree digest0a5a5c7c0573552d29e591294c061a0d3e06479403f85438b383411b4f24acf6.34742259330: PASS; v0.0.3 published.