Fix configuration HTTP deadlines across stalled frames - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A configuration request started after a long frame could immediately time out: Godot 4.7.2 charged the preceding frame to its new HTTPRequest timer. Measure the deadline from monotonic request-start time instead. Use nonblocking polling so cancelling a request whose peer withholds its response cannot block waiting for a native HTTP thread.
Preserve existing result/error contracts and add transport result metadata. Complete callbacks once, release the owned request, and validate deadlines. Prepare v0.0.2.
Validation: all four Godot test scripts pass, including real loopback HTTP after a 1.2-second frame, successful cleanup, silent-peer timeout at time scale zero, owner cleanup and disabled/invalid deadlines. CI/release use a checksum-verified Godot 4.7.2 binary and the same bounded runner, rejecting runtime errors and missing PASS markers.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.