chore: adopt the canonical biome lint+format gate - #15
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adopts the fleet's canonical lint+format gate (cicd PR #45 @ e59a84d3):
biome.jsoncopied byte-verbatim fromnicodes/cicdtemplates/static-web/biome.json(sha2562464c8cc…f91a5, matches the archetype). Zero per-repo divergence.@biomejs/biomeadded as an exact devDependency2.5.14(no range);bun.lockcarries it;bun install --frozen-lockfileverified clean..github/actions/test: the archetype's Lint and format are canonical step (bun x biome check) added as the FIRST step, before all dist assertions, with the archetype's comment adapted minimally (this repo pins in package.json; the frozen install runs in ../build earlier in the same job). The action description's step-order prose updated (the gate is a source assertion, not a dist property). All existing per-repo assertions (three-page check, no-JS) untouched.Biome findings and how they were handled
First run: 8 errors, 8 warnings, 1 info across 13 files.
bun x biome check --write(safe fixes only) and the diff inspected: frontmatter-only changes in the .astro files (import order, one-line arrow joins), template HTML untouched, CSS re-indented. That churn is the visible part of this diff.lint/correctness/noUnusedImportsonFull/Entryimports in the three pages — false positives: the components are used in the page templates, and Biome analyses .astro frontmatter only. Left visible as warnings;bun x biome checkexits 0 on warnings, so the gate is green without suppressions. NOTE for cicd: the canonical**/*.astrooverride disablesnoUnusedVariablesbut notnoUnusedImports, so every adopter with template-used component imports sees these; an archetype-side addition ofnoUnusedImports: "off"(or equivalent) to that override would clear them fleet-wide.lint/complexity/noImportantStyleson theprefers-reduced-motionblock inglobal.css— the!importantdeclarations are intentional (the block must beat every other rule to actually reduce motion). Biome's own fix is marked unsafe (it would delete them). Left visible as warnings.biome.jsonitself:"recommended": trueis deprecated in Biome 2.5.14 in favour of"preset"(biome migrate). Info-level, non-failing, fleet-wide — for cicd to act on in the archetype, not for per-repo edits (byte-verbatim rule).Sibling evidence (verified locally): tonesplit-web and ctcalc-web, both mid-adoption, hit the identical finding classes (unused-import false positives, reduced-motion
!important, the deprecation info).Local gates (bun 1.4.1)
bun x biome check: exit 0 (8 non-failing warnings + 1 info remain visible).bun install --frozen-lockfile: clean.bun run typecheck: 7 files, 0 errors/warnings/hints.bun run build: 3 pages; index/devtools/games non-empty; no*.jsindist. actionlint: clean on both workflows.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.