chore: type-check the site with astro check in CI - #12
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Mirrors tonesplit-web's shape: the site is type-checked in CI before it is built.
package.json: new devDependencies@astrojs/check^0.9.10,typescript6,@types/primer__octicons^19.21.0 (the octicons package ships no types; it is imported in all three pages and both components), and atypecheckscript (astro check)..github/actions/build: a new Type check step between Install and Build.astro checkruns its ownastro sync, so it needs nothing from./dist, and a type error is the likeliest and cheapest failure to reach.typescriptis pinned to 6: TypeScript 7's native compiler does not expose the programmatic API@astrojs/checkneeds. The action's description now states the step order.bun.lockregenerated accordingly.Local gates (bun 1.3.10)
bun run typecheck: 7 files, 0 errors, 0 warnings, 0 hints — no genuine type errors in the site.bun run build: 3 pages built.*.jsindist.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.