Skip to content

Improve case for lifecycle interface to create guest XML by the framework#6852

Open
yiqianwei wants to merge 1 commit intoautotest:masterfrom
yiqianwei:LIBVIRTAT-22423
Open

Improve case for lifecycle interface to create guest XML by the framework#6852
yiqianwei wants to merge 1 commit intoautotest:masterfrom
yiqianwei:LIBVIRTAT-22423

Conversation

@yiqianwei
Copy link
Copy Markdown
Contributor

@yiqianwei yiqianwei commented Apr 1, 2026

1.Add some parameters to allow the framework provide guest xml
2.Add "only Linux" to limit guest type
3.Skip the OVS bridge test

ID: 22423

Summary by CodeRabbit

  • Tests
    • Enhanced virtual network lifecycle test configuration: restricted to Linux, improved VM provisioning and teardown, switched to no-reboot mode, and added an OVMF-specific override affecting VM teardown behavior (uses NVRAM option).
    • Added an earlier validation to cancel/skip tests for OVS-bridge scenarios before VM setup.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4863aec8-fbc3-4cc5-890b-72cc94675772

📥 Commits

Reviewing files that changed from the base of the PR and between b85053b and 904ac97.

📒 Files selected for processing (2)
  • libvirt/tests/cfg/virtual_network/lifecycle/lifecycle_full_xml_interface.cfg
  • libvirt/tests/src/virtual_network/lifecycle/lifecycle_full_xml_interface.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • libvirt/tests/cfg/virtual_network/lifecycle/lifecycle_full_xml_interface.cfg

Walkthrough

The PR updates a virtual network test configuration to restrict execution to Linux, enable libvirt VM creation and teardown, set no-reboot mode, and add an OVMF-specific libvirt kill option (--nvram). The test runner now invokes an OVS-bridge cancellation check at the start of run() (before determining the main VM and backing up VM XML), introducing an earlier conditional skip point prior to the existing setup/start/check/teardown lifecycle.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes adding framework-driven guest XML creation for lifecycle interface testing, which aligns with the PR's main objective of allowing the framework to provide guest XML and adding configuration parameters to support this.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…work

1.Add some parameters to allow the framework provide guest xml
2.Add "only Linux" to limit guest type
3.Skip the OVS bridge test

Signed-off-by: Yiqian Wei <yiwei@redhat.com>
@yiqianwei
Copy link
Copy Markdown
Contributor Author

Test results:
ovs bridge:
(1/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.network.q35: CANCEL: Host does not use Linux Bridge (10.61 s)
(2/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.linux_bridge.q35: CANCEL: Host does not use Linux Bridge (10.89 s)
(3/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.ethernet.q35: CANCEL: Host does not use Linux Bridge (10.59 s)
(4/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.direct_bridge.q35: CANCEL: Host does not use Linux Bridge (10.75 s)

linux bridge:
(1/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.network.q35: PASS (147.41 s)
(2/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.linux_bridge.q35: PASS (216.78 s)
(3/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.ethernet.q35: PASS (145.91 s)
(4/4) Host_RHEL.m9.u8.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.2.x86_64.io-github-autotest-libvirt.virtual_network.lifecycle.lifecycle_full_xml_interface.direct_bridge.q35: PASS (132.19 s)

@yiqianwei
Copy link
Copy Markdown
Contributor Author

@yanglei-rh , Could you help to review this patch? thanks

Copy link
Copy Markdown
Contributor

@nickzhq nickzhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants