chore: improve argument handling and error messages - #722
Merged
Merged
Conversation
tstirrat15
marked this pull request as ready for review
September 4, 2026 00:20
tstirrat15
force-pushed
the
tstirrat/improve-arg-handling
branch
from
September 4, 2026 00:20
2da9182 to
e1e642c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
miparnisari
reviewed
Sep 4, 2026
miparnisari
previously approved these changes
Sep 4, 2026
tstirrat15
force-pushed
the
tstirrat/improve-arg-handling
branch
from
September 4, 2026 00:41
e1e642c to
aec31c8
Compare
miparnisari
enabled auto-merge (squash)
September 4, 2026 00:52
miparnisari
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written with LLM assistance.
Description
I ran into this when I fatfingered a
zed permission lookup-resourcestoday. The error looks like this:Which is cryptic and doesn't indicate where the issue is - it sounds like it could as easily be a gRPC internal error as a malformed input error.
This PR improves the error output so that it points at the specific arg and provides a template.
Changes
Testing
Review. See that tests pass. do
go run ./cmd/... permission lookup-resources thumper/user:someuser view thumper/resourceand see that you get more useful output.