feat(auth0-server-js): add challengePasswordlessDbConnection and complete PasswordlessDbConnection - #280
Open
Piyush-85 wants to merge 1 commit into
Open
feat(auth0-server-js): add challengePasswordlessDbConnection and complete PasswordlessDbConnection#280Piyush-85 wants to merge 1 commit into
Piyush-85 wants to merge 1 commit into
Conversation
…letePasswordlessDbConnection
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds database-connection passwordless (OTP) support to ServerClient, exposing the two-step flow that @auth0/auth0-auth-js already implements but ServerClient never surfaced.
New methods:
Both methods resolve the domain per call and work in static and resolver (multi-tenant) modes.
Companion fix: completePasswordless and completePasswordlessMagicLink were missing applySessionExpiryAtLogin, unlike completeInteractiveLogin and mfa.verify. Both now stamp the IPSIE session_expiry ceiling at login — additive and no-op unless the tenant configures a session-expiry policy.
New re-exports: ChallengeWithEmailOptions, ChallengeWithPhoneNumberOptions, PasswordlessChallenge, TokenByPasswordlessDbConnectionOptions, PasswordlessChallengeError, PasswordlessDbGetTokenError.
Testing
Tested with npm test in packages/auth0-server-js — all 515 tests pass. TypeScript clean via npx tsc --noEmit --project tsconfig.test.json.
7 new unit tests cover: email and phone challenge dispatching (no session written), OTP exchange with fresh session write, scope non-injection, IPSIE session_expiry ceiling stamping, mfa_required propagation with isMfaRequiredError narrowing, fullResponse, and resolver (multi-tenant) mode.
Checklist