Repository navigation
ESP/Speaker: Harden polling, logging, and amplifier startup - #170
Merged
Merged
Conversation
Use a 5 second retry period when no monitoring period is available, and reject a configured monPeriod of zero. This prevents an unconfigured or zero-configured device from issuing poll requests every loop iteration.
get_logs() previously used ESP_ERROR_CHECK when rotating log files, so an SD card write failure would abort the firmware. Return -1 instead and let the log reader handle the failure gracefully, which is important when the SD card is failing at runtime (#121).
Explicitly initialise scl_wait_us and flags so the build is clean under -Wmissing-designated-field-initializers. A zero timeout uses the driver default.
Avoid a build-time assertion when the pin count is configured low by sizing the temporary config buffer to the larger of the IO and WiFi field lengths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #169.