Skip to content

ci(expo): align the appium app without a second expo install - #249

Merged
brax10ward merged 1 commit into
masterfrom
braxton/sdk-926-sync-appium-expo-deps-from-example
Oct 20, 2026
Merged

brax10ward merged 1 commit into
masterfrom
braxton/sdk-926-sync-appium-expo-deps-from-example

Conversation

@brax10ward

@brax10ward brax10ward commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #246: a second expo install --fix in the appium app crashes with ERR_MODULE_NOT_FOUND because Yarn re-hoists the @expo/cli it is running from, which broke Prepare on #244. The appium app now copies the example's Expo-managed versions before a single yarn install, so only one Expo CLI install changes dependencies per run. On #244's head this reproduces the crash with the old script, and with the new one it aligns all three manifests and passes deps:expo:check and the validator from master.

Linear Link

Refs SDK-926

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which cleans up code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change impacts security

Checklist:

  • New and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have tested on a physical iOS device and Android device
  • I have added tests that prove my fix is effective or that my feature works
  • I have followed the Code Review and Code Review Security guidelines
  • I have checked my code against flaws from the OWASP Top 10
    • A01:2021-Broken Access Control
    • A02:2021-Cryptographic Failures
    • A03:2021-Injection
    • A04:2021-Insecure Design
    • A05:2021-Security Misconfiguration
    • A06:2021-Vulnerable and Outdated Components
    • A07:2021-Identification and Authentication Failures
    • A08:2021-Software and Data Integrity Failures
    • A09:2021-Security Logging and Monitoring Failures
    • A10:2021-Server-Side Request Forgery

@brax10ward
brax10ward marked this pull request as ready for review October 20, 2026 17:03
@brax10ward
brax10ward requested a review from a team as a code owner October 20, 2026 17:03
@brax10ward
brax10ward merged commit c22d7d6 into master Oct 20, 2026
5 checks passed
@brax10ward
brax10ward deleted the braxton/sdk-926-sync-appium-expo-deps-from-example branch October 20, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants